Fix use of uninitialized variables in FAST.Farm and increase stack size in Visual Studio #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule These members of the InflowWind initialization input DDT weren't being initialized and could potentially cause issues in the code when using FAST.Farm. Fixed by initializing values.
The array p_AD%FVW%Bld2Wings was indexed with iRot even if the array hadn't been allocated. This is not valid code, which was fixed by adding an if statement to only use the array if WakeMod is FVW
andrew-platt
approved these changes
Mar 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged
Feature or improvement description
This PR fixes the use of uninitialized variables when running FAST.Farm. Initialization of
IfW_InitInp%MHK,IfW_InitInp%WtrDpth, andIfW_InitInp%MSL2SWLwere added to AWAE. Slicing of an unallocated array was also fixed inAeroDyn_AllBldNdOuts_IO.f90. This PR also increases the stack size when building with Visual Studio.Related issue, if one exists
#2053
Impacted areas of the software
AeroDyn_AllBldNdOuts_IO.f90AWAE.f90