lagrangian: Spray/BreakupModel/PilchErdman: Correction to function fo…

…r dimensionless time Resolves bug report https://bugs.openfoam.org/view.php?id=4063
OpenFOAM · Mar 12, 2024 · 71b07bb · 71b07bb
1 parent bf2b19e
commit 71b07bb
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 12 deletions.
diff --git a/src/lagrangian/parcel/submodels/Spray/BreakupModel/PilchErdman/PilchErdman.C b/src/lagrangian/parcel/submodels/Spray/BreakupModel/PilchErdman/PilchErdman.C
@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2024 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -114,8 +114,14 @@ bool Foam::PilchErdman<CloudType>::update
             }
             else if (We > 45)
             {
-                // bag-and-stamen breakup  - eq (10)
-                taubBar = 14.1*pow(We - 12.0, 0.25);
+                // bag-and-stamen breakup - eq (10)
+                //
+                // *** Note that the exponent is erroneously negated in the
+                // original reference. This expression matches the second
+                // reference and results in a continuous expression for
+                // taubBar.
+                //
+                taubBar = 14.1*pow(We - 12.0, -0.25);
             }
             else if (We > 18)
             {

diff --git a/src/lagrangian/parcel/submodels/Spray/BreakupModel/PilchErdman/PilchErdman.H b/src/lagrangian/parcel/submodels/Spray/BreakupModel/PilchErdman/PilchErdman.H
@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2024 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -25,15 +25,20 @@ Class
     Foam::PilchErdman
 
 Description
-    Particle secondary breakup model, based on the reference:
+    Particle secondary breakup model, based on the references:
 
-    @verbatim
-    Pilch, M. and Erdman, C.A.
-    "Use of breakup time data and velocity history data
-     to predict the maximum size of stable fragments for acceleration
-     induced breakup of a liquid drop."
-    Int. J. Multiphase Flows 13 (1987), 741-757
-    @endverbatim
+    \verbatim
+    Pilch, M., & Erdman, C. A. (1987).
+    Use of breakup time data and velocity history data to predict the maximum
+    size of stable fragments for acceleration-induced breakup of a liquid drop.
+    International journal of multiphase flow, 13(6), 741-757.
+    \endverbatim
+
+    \verbatim
+    Guildenbecher, D. R., López-Rivera, C., & Sojka, P. E. (2009).
+    Secondary atomization.
+    Experiments in Fluids, 46(3), 371-402.
+    \endverbatim
 
     The droplet fragment velocity is described by the equation:
 
@@ -64,6 +69,7 @@ Description
 
 namespace Foam
 {
+
 /*---------------------------------------------------------------------------*\
                          Class PilchErdman Declaration
 \*---------------------------------------------------------------------------*/