Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
velo committed Aug 29, 2023
1 parent a74dbd7 commit 2852b6a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion core/src/main/java/feign/AsyncFeign.java
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public AsyncFeign<C> internalBuild() {
decoder,
errorDecoder,
dismiss404,
closeAfterDecode, decodeVoid, executionChain()),
closeAfterDecode, decodeVoid, responseInterceptorChain()),
AsyncResponseHandler.class,
capabilities);

Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/feign/BaseBuilder.java
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ public final T build() {

protected abstract T internalBuild();

protected ResponseInterceptor.Chain executionChain() {
protected ResponseInterceptor.Chain responseInterceptorChain() {
ResponseInterceptor.Chain endOfChain =
ResponseInterceptor.Chain.DEFAULT;
ResponseInterceptor.Chain executionChain = this.responseInterceptors.stream()
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/feign/Feign.java
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ public <T> T target(Target<T> target) {
public Feign internalBuild() {
final ResponseHandler responseHandler =
new ResponseHandler(logLevel, logger, decoder, errorDecoder,
dismiss404, closeAfterDecode, decodeVoid, executionChain());
dismiss404, closeAfterDecode, decodeVoid, responseInterceptorChain());
MethodHandler.Factory<Object> methodHandlerFactory =
new SynchronousMethodHandler.Factory(client, retryer, requestInterceptors,
responseHandler, logger, logLevel, propagationPolicy,
Expand Down

0 comments on commit 2852b6a

Please sign in to comment.