Use LinkedHashMap for deterministic iterations

OpenFeign · Jan 28, 2020 · 3454156 · 3454156
1 parent 17735a3
commit 3454156
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/mock/src/main/java/feign/mock/RequestHeaders.java b/mock/src/main/java/feign/mock/RequestHeaders.java
@@ -17,14 +17,14 @@
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.Map;
 
 public class RequestHeaders {
 
   public static class Builder {
 
-    private Map<String, Collection<String>> headers = new HashMap<String, Collection<String>>();
+    private Map<String, Collection<String>> headers = new LinkedHashMap<String, Collection<String>>();
 
     private Builder() {}
 

diff --git a/mock/src/test/java/feign/mock/RequestHeadersTest.java b/mock/src/test/java/feign/mock/RequestHeadersTest.java
@@ -83,6 +83,6 @@ public void shouldPrintHeaders() {
         .add("other header", "val2")
         .add("header", Arrays.asList("val3", "val4"))
         .build();
-    assertThat(headers.toString()).isEqualTo("other header=[val2], header=[val, val3, val4]");
+    assertThat(headers.toString()).isEqualTo("header=[val, val3, val4], other header=[val2]");
   }
 }