Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes vnd header regression by changing Headers encoding
I mistakenly advised `@Headers` to follow the encoding rules of `@Body`. This was a a mistake as in both cases, url encoding is a bad choice, if the only goal is to prevent accidental variable expansion. For example, url encoding interferes a lot with content, including messing with '+' characters, such as exist in "Accept: application/vnd.github.v3+json" This changes `@Headers` to only address the problem, which where a '{' literal is desired in a header value. The solution offered here is to simply repeat "{{" when you desire a '{' literal. For example, if your header value needs to be literally "{{variable}}", you'd encode it as "{{{{variable}}". The impact of this change is limited to those who have already started using v8.15, and a fast release will occur after merge to limit that. See #326 Fixes #345 Closes #346
- Loading branch information
Adrian Cole
committed
Mar 9, 2016
1 parent
b29f9d8
commit 57444d1
Showing
2 changed files
with
36 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters