Consolidates entrypoint where Hystrix is configured (#446)

OpenFeign · Aug 17, 2016 · b6bf1ca · b6bf1ca
1 parent 7850eb0
commit b6bf1ca
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 20 deletions.
diff --git a/hystrix/src/main/java/feign/hystrix/HystrixFeign.java b/hystrix/src/main/java/feign/hystrix/HystrixFeign.java
@@ -38,14 +38,7 @@ public static final class Builder extends Feign.Builder {
      * @see #target(Class, String, Object)
      */
     public <T> T target(Target<T> target, final T fallback) {
-      super.invocationHandlerFactory(new InvocationHandlerFactory() {
-        @Override
-        public InvocationHandler create(Target target, Map<Method, MethodHandler> dispatch) {
-          return new HystrixInvocationHandler(target, dispatch, fallback);
-        }
-      });
-      super.contract(new HystrixDelegatingContract(contract));
-      return super.build().newInstance(target);
+      return buildWithFallback(fallback).newInstance(target);
     }
 
     /**
@@ -100,7 +93,17 @@ public Builder contract(Contract contract) {
 
     @Override
     public Feign build() {
-      super.invocationHandlerFactory(new HystrixInvocationHandler.Factory());
+      return buildWithFallback(null);
+    }
+
+    /** Configures components needed for hystrix integration. */
+    Feign buildWithFallback(final Object nullableFallback) {
+      super.invocationHandlerFactory(new InvocationHandlerFactory() {
+        @Override public InvocationHandler create(Target target,
+            Map<Method, MethodHandler> dispatch) {
+          return new HystrixInvocationHandler(target, dispatch, nullableFallback);
+        }
+      });
       super.contract(new HystrixDelegatingContract(contract));
       return super.build();
     }

diff --git a/hystrix/src/main/java/feign/hystrix/HystrixInvocationHandler.java b/hystrix/src/main/java/feign/hystrix/HystrixInvocationHandler.java
@@ -19,15 +19,13 @@
 import com.netflix.hystrix.HystrixCommandGroupKey;
 import com.netflix.hystrix.HystrixCommandKey;
 
-import com.netflix.hystrix.HystrixCommandProperties;
 import java.lang.reflect.InvocationHandler;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.lang.reflect.Proxy;
 import java.util.LinkedHashMap;
 import java.util.Map;
 
-import feign.InvocationHandlerFactory;
 import feign.InvocationHandlerFactory.MethodHandler;
 import feign.Target;
 import rx.Completable;
@@ -183,12 +181,4 @@ public int hashCode() {
   public String toString() {
     return target.toString();
   }
-
-  static final class Factory implements InvocationHandlerFactory {
-
-    @Override
-    public InvocationHandler create(Target target, Map<Method, MethodHandler> dispatch) {
-      return new HystrixInvocationHandler(target, dispatch, null);
-    }
-  }
-}
+}