-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feign can not handle ;
correctly
#1123
Comments
Hi @aftersss Thank you for bringing this to our attention. This is a known issue related to our template handling. We are working on a fix for this, however; in the meantime, you will need to pct-encode the semi-colon For more information on the underlying problem, see these other issues:
|
Fixes OpenFeign#1123, Fixes OpenFeign#1133, Fixes OpenFeign#1102 Ensures that all expressions are fully-encoded before being manipulated during template expansion. This allows parameters to include reserved values and result in properly encoded results. Additionally, `Iterable` values are now handled in accordance with RFC 6570 allowing for the specified `CollectionFormat` to be applied correctly.
Fixes OpenFeign#1123, Fixes OpenFeign#1133, Fixes OpenFeign#1102, Fixes OpenFeign#1028 Ensures that all expressions are fully-encoded before being manipulated during template expansion. This allows parameters to include reserved values and result in properly encoded results. Additionally, `Iterable` values are now handled in accordance with RFC 6570 allowing for the specified `CollectionFormat` to be applied and empty parameters to be expanded correctly as this is the main use case that exhibited this issue.
Fixes OpenFeign#1123, Fixes OpenFeign#1133, Fixes OpenFeign#1102, Fixes OpenFeign#1028 Ensures that all expressions are fully-encoded before being manipulated during template expansion. This allows parameters to include reserved values and result in properly encoded results. Additionally, `Iterable` values are now handled in accordance with RFC 6570 allowing for the specified `CollectionFormat` to be applied and empty parameters to be expanded correctly as this is the main use case that exhibited this issue.
…hub.com/kdavisk6/feign into OpenFeigngh-1123-correct-list-expansion
* Ensure Iterable values are encoded before template expansion Fixes #1123, Fixes #1133, Fixes #1102, Fixes #1028 Ensures that all expressions are fully-encoded before being manipulated during template expansion. This allows parameters to include reserved values and result in properly encoded results. Additionally, `Iterable` values are now handled in accordance with RFC 6570 allowing for the specified `CollectionFormat` to be applied and empty parameters to be expanded correctly as this is the main use case that exhibited this issue.
spring-cloud version: Greenwich.SR3
spring-boot-version: 2.1.9.RELEASE
I wrote the following feign interface:
and then invoke it via feign like this:
Case 1 :
the expected output should be:
hello;world
, but actually I got:hello,world
,Case 2:
the expected output should be:
["hello;world"]
, but actually I got:["hello", "world"]
,See also: spring-cloud/spring-cloud-openfeign#246
The text was updated successfully, but these errors were encountered: