-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JEP 118 parameters #1297
Labels
enhancement
For recommending new capabilities
feedback provided
Feedback has been provided to the author
Comments
If you think this is a good addition to feign I could work on it. |
Awesome, that would be most appreciated! |
krzyk
added a commit
to krzyk/feign
that referenced
this issue
Nov 12, 2020
JEP 118 introduced javac option `-parameters` that adds to bytecode method parameter names, so if code is compiled with that option and @param value is empty we can get that template parameter name from method parameter name. Fixes OpenFeign#1297.
krzyk
added a commit
to krzyk/feign
that referenced
this issue
Nov 13, 2020
JEP 118 introduced javac option `-parameters` that adds to bytecode method parameter names, so if code is compiled with that option and @param value is empty we can get that template parameter name from method parameter name. Fixes OpenFeign#1297.
krzyk
added a commit
to krzyk/feign
that referenced
this issue
Nov 13, 2020
JEP 118 introduced javac option `-parameters` that adds to bytecode method parameter names, so if code is compiled with that option and @param value is empty we can get that template parameter name from method parameter name. Fixes OpenFeign#1297.
krzyk
added a commit
to krzyk/feign
that referenced
this issue
Nov 24, 2020
JEP 118 introduced javac option `-parameters` that adds to bytecode method parameter names, so if code is compiled with that option and @param value is empty we can get that template parameter name from method parameter name. Fixes OpenFeign#1297.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
For recommending new capabilities
feedback provided
Feedback has been provided to the author
I haven't seen this issue, but it is quite hard to search for this so sorry for duplicate.
Java 8 introduced an additional javac option in (JEP 118) using
-parameters
to allow retrieval of parameter names during runtime.This retrieval is supported in e.g. Spring and Jackson to reduce amount of duplication, so I think it would be good to have it in feign also.
E.g. I have following method in interface:
As you see the same name is both in the parameter name as well as in annotation, if
-parameters
would be supported this could be simplified to:Currently (in 9.7.0) it is not supported because
value
in@Param
annotation is required.The text was updated successfully, but these errors were encountered: