Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feign.Builder #34

Closed
codefromthecrypt opened this issue Aug 4, 2013 · 1 comment
Closed

Add Feign.Builder #34

codefromthecrypt opened this issue Aug 4, 2013 · 1 comment

Comments

@codefromthecrypt
Copy link
Contributor

For those who do not use dagger, or do not wish to, we could expose a builder which defines all dependencies explicitly that can be provided. This includes logging config, decoders, etc. This could be modeled similarly to retrofit RestAdapter.Builder or jclouds ContextBuilder

ex.

api = Feign.builder()
                .loggingLevel(BASIC)
                .decoder(customType)
                .target(GitHub.class, "http://foo");

Note that this will still use dagger under the scenes, albeit via reflection. When/if someone wants to switch to pure dagger, they could use the module system directly.

cc @benjchristensen

@davidmc24 davidmc24 mentioned this issue Aug 23, 2013
5 tasks
@davidmc24
Copy link
Contributor

I've started work on this. Expect a pull request sometime tonight.

codefromthecrypt pushed a commit that referenced this issue Sep 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants