-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FeignException with content as separate field #642
Comments
@scythepl this is an enhancement. Let's mark it as such. |
@scythepl, are you talking about parsing the response body from content: part of the FeignException message? If so this makes sense because passing the response body and the status upstream is a common and valid use case. Someone consuming the FeignClient shouldn't be handling parsing the feign specific message content. As @kdavisk6 states we can mark this as an enhancement and implement in an upcoming release. |
@orwashere yes, that's exactly what I was talking about. Sorry if it wasn't clear. I can't really find an option to mark this issue in any way, maybe it's a permissions thing? I'm not a fluent github issue tracker user, I'm sorry. To sum up, here's what I think would be good:
|
@scythepl If you feel particularly jazzed about this, why not attempt a PR? Checkout HACKING and experiment. |
Hello, @kdavisk6 ! |
Of course. Please read Contributing and Hacking for information on how to contribute. |
any idea which version of spring-cloud-openfiegn includes this fix |
This change was merged and release over a year ago. Using the most recent version of Spring Cloud should include this update. |
FeignException includes returned content in message. While this is mostly OK (unless the returned content is very long), the exception could also provide a separate field to obtain the content itself for further parsing instead of having to parse the message for it.
The text was updated successfully, but these errors were encountered: