-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@QueryMap not working with POJOs as specified in documentation #691
Comments
I don't believe this feature is available in the released versions. It's been accepted to |
DO you know when 9.7 is going live? |
I think, by the end of the week
…On Sun, Apr 29, 2018, 03:39 Michal ***@***.***> wrote:
DO you know when 9.7 is going live?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#691 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIVjtHgZ1SFEGfS0JUq-zgwAb-G7Lhkks5ttI0cgaJpZM4Tp4jl>
.
|
9.7 was released. |
@doublemc Are you still experiencing this issue with 9.7? |
Bug is still present, neither 9.7 nor 10.0.1 solve the Issue.
No QueryMapEncoder is used, as mentioned in the docs.
|
Do you have a small failing test case example? |
I'm looking at the latest code and line 126 in feign/core/src/main/java/feign/Contract.java Lines 125 to 128 in 17a515e
Are you sure you are using the right |
While trying to reproduce it again in a separate sample project, i was not able to. Sorry for the inconvenience and the late response, been busy the last weeks. |
According to: https://github.com/OpenFeign/feign#dynamic-query-parameters it should be possible to write:
@RequestLine("GET /api/v1/historicalTrades") fun getHistoricalTrades(@QueryMap orderBookQuery: OrderBookQuery): List<TradeEntry>
where OrderBookQuery looks like that:
data class OrderBookQuery(val symbol: String, val limit: Int? = 100)
Feign should generate:
/api/v1/historicalTrades?symbol={symobl}&limit={limit}
but I'm getting:Here is my config and usage that produces above exception:
Link to my SO if someone wants to get them free karma points ;) : https://stackoverflow.com/questions/50044283/feign-querymap-usage-with-pojo
The text was updated successfully, but these errors were encountered: