Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LinkedHashMap for deterministic iterations #1165

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Use LinkedHashMap for deterministic iterations #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions mock/src/main/java/feign/mock/RequestHeaders.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright 2012-2019 The Feign Authors
* Copyright 2012-2020 The Feign Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
Expand All @@ -17,14 +17,15 @@
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;

public class RequestHeaders {

public static class Builder {

private Map<String, Collection<String>> headers = new HashMap<String, Collection<String>>();
private Map<String, Collection<String>> headers =
new LinkedHashMap<String, Collection<String>>();

private Builder() {}

Expand Down
4 changes: 2 additions & 2 deletions mock/src/test/java/feign/mock/RequestHeadersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright 2012-2019 The Feign Authors
* Copyright 2012-2020 The Feign Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
Expand Down Expand Up @@ -83,6 +83,6 @@ public void shouldPrintHeaders() {
.add("other header", "val2")
.add("header", Arrays.asList("val3", "val4"))
.build();
assertThat(headers.toString()).isEqualTo("other header=[val2], header=[val, val3, val4]");
assertThat(headers.toString()).isEqualTo("header=[val, val3, val4], other header=[val2]");
}
}