Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Level Multiple Inheritance and Override Support #1285

Closed
wants to merge 1 commit into from

Conversation

silkentrance
Copy link
Contributor

@silkentrance silkentrance commented Oct 10, 2020

WIP please review and comment!

See Also

#1284

@silkentrance
Copy link
Contributor Author

silkentrance commented Oct 10, 2020

The command "./travis/no-git-changes.sh" exited with 1.

why is that? what is needed to make the build, which otherwise succeeeded flawlessly, not fail?

okay, I just ran mvn clean install as described in the above mentioned script. Still not understanding how this works, though...

@kdavisk6
Copy link
Member

kdavisk6 commented Nov 3, 2020

Thank you for your work on this. I will need some time to read through and review this completely. This has been attempted a few times before and has proved difficult to get right. I will need a few days.

@kdavisk6 kdavisk6 self-assigned this Nov 3, 2020
@kdavisk6 kdavisk6 added the waiting for feedback Issues waiting for a response from either to the author or other maintainers label Nov 3, 2020
@silkentrance
Copy link
Contributor Author

@kdavisk6 TIA for your review. Please note that the current build fails due to some deactivated modules. I also have an issue with a license header somewhere which I was unable to resolve. I will try to get the build working again soon.

@silkentrance silkentrance marked this pull request as draft December 28, 2020 19:07
@silkentrance
Copy link
Contributor Author

silkentrance commented Dec 28, 2020

@kdavisk6 I have reestablished the original pom parent and reenabled disabled modules and plugins. Please comment on the existing PR.

@silkentrance
Copy link
Contributor Author

rebased to upstream/master

@silkentrance
Copy link
Contributor Author

silkentrance commented Dec 28, 2020

local builds are failing due to

Cannot resolve plugin com.spotify:docker-maven-plugin:<unknown>

dunno what this is about...

@kdavisk6
Copy link
Member

The docker usage comes from the experimental Annotation Processor project. I'll look into what I can do, but for now I recommend removing the <module>apt-test-generator</module> from the parent pom.

@silkentrance
Copy link
Contributor Author

@kdavisk6 i do not get any response from the build check...

@silkentrance
Copy link
Contributor Author

@kdavisk6 I get the error about the missing plugin version only when running maven from inside IntelliJ.... and that poses a lot of different other problems, too. Running the tests from the console seems to working just fine.

@kdavisk6
Copy link
Member

WRT to the build checks, I've had to move our build system from Travis to CircleCI since the version of Travis we are using is shutting down. Please ensure that you have a .circleci folder in your workspace. The check will begin working again once the Circle Ci configuration is present in your fork.

@silkentrance
Copy link
Contributor Author

@kdavisk6 circleci confiiguration is present

rebased to current master

@silkentrance silkentrance marked this pull request as ready for review December 28, 2020 20:30
@kdavisk6
Copy link
Member

I'm not sure why the "old" build check is set for your branch. I'll temporarily disable the required check and see if that updates this Pull Request.

@silkentrance
Copy link
Contributor Author

I'll do a force push.

@silkentrance
Copy link
Contributor Author

silkentrance commented Dec 28, 2020

On second thought, I will wait a bit longer for the forced push.

@silkentrance
Copy link
Contributor Author

@kdavisk6 BTW what are your experiences with this PR? does it work out or does it fail under edge conditions?

@kdavisk6
Copy link
Member

I apologize, I have not been able to give this change the attention it deserves. I've been heads down on the Travis retirement over the holidays. I have a few more housekeeping tasks to complete this week and then I'll shift my attention to this.

@silkentrance
Copy link
Contributor Author

Take your time.

Just to mention, I have a project here (private) that uses multiple inheritance at the second level and it works just fine, keeping the original contract (one interface, one super interface) intact.

@silkentrance
Copy link
Contributor Author

I will close this PR and open up a new one, since the build check is not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for feedback Issues waiting for a response from either to the author or other maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants