New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi Level Multiple Inheritance and Override Support #1285
Conversation
The command "./travis/no-git-changes.sh" exited with 1. why is that? what is needed to make the build, which otherwise succeeeded flawlessly, not fail? okay, I just ran |
9565398
to
b318a6d
Compare
Thank you for your work on this. I will need some time to read through and review this completely. This has been attempted a few times before and has proved difficult to get right. I will need a few days. |
@kdavisk6 TIA for your review. Please note that the current build fails due to some deactivated modules. I also have an issue with a license header somewhere which I was unable to resolve. I will try to get the build working again soon. |
5914009
to
37f90ce
Compare
@kdavisk6 I have reestablished the original pom parent and reenabled disabled modules and plugins. Please comment on the existing PR. |
37f90ce
to
b2cc004
Compare
rebased to upstream/master |
local builds are failing due to
dunno what this is about... |
The |
@kdavisk6 i do not get any response from the build check... |
@kdavisk6 I get the error about the missing plugin version only when running maven from inside IntelliJ.... and that poses a lot of different other problems, too. Running the tests from the console seems to working just fine. |
WRT to the build checks, I've had to move our build system from Travis to CircleCI since the version of Travis we are using is shutting down. Please ensure that you have a |
b2cc004
to
317756a
Compare
@kdavisk6 circleci confiiguration is present rebased to current master |
I'm not sure why the "old" build check is set for your branch. I'll temporarily disable the required check and see if that updates this Pull Request. |
I'll do a force push. |
9859183
to
9eddbf1
Compare
On second thought, I will wait a bit longer for the forced push. |
@kdavisk6 BTW what are your experiences with this PR? does it work out or does it fail under edge conditions? |
9eddbf1
to
0b2b2ea
Compare
e97d5d6
to
b46c58d
Compare
I apologize, I have not been able to give this change the attention it deserves. I've been heads down on the Travis retirement over the holidays. I have a few more housekeeping tasks to complete this week and then I'll shift my attention to this. |
Take your time. Just to mention, I have a project here (private) that uses multiple inheritance at the second level and it works just fine, keeping the original contract (one interface, one super interface) intact. |
I will close this PR and open up a new one, since the build check is not working. |
WIP please review and comment!
See Also
#1284