Fix for #1286

[velo]

When feign is done with the response, also invoke close on http response (if closeable)

#1286

[austinpio]

could this close method call be enclosed in a finally block? that would ensure the socket is released even in the event of an exception when consuming the entity.
It is also the approach recommended here - https://hc.apache.org/httpcomponents-client-ga/quickstart.html
quoted text from the document

// In order to ensure correct deallocation of system resources
// the user MUST call CloseableHttpResponse#close() from a finally clause.
try{
EntityUtils.consume(entity1);
} finally {
response1.close();
}

• Additionally it would also not show up as a potential issue in static code analyzers like Fortify, which expect to see a finally block which closes the connection.

[austinpio]

hi @velo you reckon, this finally block is something we could incorporate in here?

[velo]

good point, lemme me do it

[austinpio]

That would be really great. Thank you @velo

[austinpio]

Requesting changes

[aleks-demin]

    final HttpEntity entity = httpResponse.getEntity();
    if (entity == null) {
      return null;
    }

apache response won't be closed in case of missing entity.
Is this case should be handled as well?