Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow QueryMapEncoder accept null value #1463

Closed
wants to merge 2 commits into from
Closed

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jul 21, 2021

	@GetMapping
	public Paged<User> list(int page, int size, @QueryMap User user);

Currently feign doesn't accept null user

Paged<User> paged = userClient.list(1, 10, new User()); // query map will include primitive type default values which is unexpected
Paged<User> paged = userClient.list(1, 10, null); // will leave query map empty

@velo velo closed this Jul 7, 2022
@quaff
Copy link
Contributor Author

quaff commented Jul 11, 2022

Closed without any comment?

@velo
Copy link
Member

velo commented Jul 11, 2022

I batch closed all old PRs that I either had conflicts or the build didn't pass. If you manage to re-submit it in the next days, I can review and get it merged asap

@velo velo reopened this Jul 11, 2022
@velo
Copy link
Member

velo commented Jul 11, 2022

seems this one is a broken build

@velo velo closed this Jul 11, 2022
@quaff
Copy link
Contributor Author

quaff commented Jul 11, 2022

It seems formatting issue

The following files have formatting changes:
+ git status --porcelain
 M core/src/test/java/feign/querymap/BeanQueryMapEncoderTest.java
 M core/src/test/java/feign/querymap/FieldQueryMapEncoderTest.java

Do you think this improvement is reasonable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants