-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor coroutine feign #1754
Refactor coroutine feign #1754
Conversation
0ccbbcf
to
9136d73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding job.
Just a small change to add methodInfoResolver
attribute to Corotine builder. Same as AsyncFeign builder
.responseInterceptor(responseInterceptor) | ||
.invocationHandlerFactory(invocationHandlerFactory) | ||
.defaultContextSupplier((AsyncContextSupplier<Object>) defaultContextSupplier) | ||
.methodInfoResolver(KotlinMethodInfo::createInstance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be extracted to an attribute on the builder and let people override if needed?
Also, that is necessary to allow coroutine methodInfoResolver
to be enriched
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean to allow the CoroutineBuilder to set the methodInfoResolver, and also provide an option to enrich the methodInfoResolver using Capability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a new PR #1762
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Perfect
Work on the [feedback](OpenFeign#1754 (comment)) of PR OpenFeign#1754
* Add methodInfoResolver attribute to Coroutinebuilder Work on the [feedback](#1754 (comment)) of PR #1754
If you want to see the final result, see PR #1757
Eliminates the possibility of breaking changes following AsyncFeign's refactoring in advance
TODO