Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalized to Decoder.TextStream and Encoder.Text; Provides.Type.SET binding #20

Merged
merged 2 commits into from
Jul 15, 2013

Conversation

codefromthecrypt
Copy link
Contributor

This smoothes out conceptual gaps relating to how encoders decoders act and how they are specified. This also allows for us to hook in binary types, should we in the future desire to.

  • changed codec to be similar to WebSocket JSR 356
    • Decoder is now Decoder.TextStream<T>
    • BodyEncoder is now Encoder.Text<T>
    • FormEncoder is now Encoder.Text<Map<String, ?>>
  • Encoder and Decoders are specified via Provides.Type.SET binding.
  • Default Encoder and Form Encoder is Encoder.Text<Object>
  • Default Decoder is Decoder.TextStream<Object>
  • ErrorDecoder now returns Exception, not fallback.
  • There can only be one ErrorDecoder and Request.Options binding now.

@cloudbees-pull-request-builder

feign-pull-requests #36 SUCCESS
This pull request looks good

codefromthecrypt pushed a commit that referenced this pull request Jul 15, 2013
Normalized to Decoder.TextStream and Encoder.Text; Provides.Type.SET binding
@codefromthecrypt codefromthecrypt merged commit 8780a0c into master Jul 15, 2013
@codefromthecrypt codefromthecrypt deleted the websocket-decoder branch July 15, 2013 21:39
velo pushed a commit to velo/feign that referenced this pull request Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants