Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApacheHttp5Client uses Options to follow Redirects #2104

Merged
merged 8 commits into from Jun 22, 2023
Merged

ApacheHttp5Client uses Options to follow Redirects #2104

merged 8 commits into from Jun 22, 2023

Conversation

ShubhamDagar
Copy link
Contributor

@ShubhamDagar ShubhamDagar commented Jun 22, 2023 •
edited

Fixes #2060

@ShubhamDagar ShubhamDagar mentioned this pull request Jun 22, 2023
Closed
@vitalijr2
Copy link
Collaborator

Hi Shubham,

some tips for you:

  • you need to run mvn clean install locally then push formatted changes
  • be aware of some files that you do not change, e.g. example-wikipedia-with-springboot/pom.xml, jaxb-jakarta/pom.xml, okhttp/pom.xml

@ShubhamDagar
Copy link
Contributor Author

@radio-rogal I have formatted the code, please review and merge. I hope you will cancel your PR

@vitalijr2 vitalijr2 requested a review from velo June 22, 2023 18:21
@vitalijr2 vitalijr2 mentioned this pull request Jun 22, 2023
Closed
@vitalijr2
Copy link
Collaborator

I hope @velo can do it.

@vitalijr2
Copy link
Collaborator

vitalijr2 commented Jun 22, 2023 •
edited

One small detail: could you add to the PR description this text?

Fixes #2060

It references the original issue then closes it when PR is merging.

@velo velo merged commit 4c17b87 into OpenFeign:master Jun 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velo velo velo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable/Disable followRedirects via Request.Options in ApacheHttp5Client
3 participants
@ShubhamDagar @vitalijr2 @velo