Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for request body gzip Content-Encoding #2247

Merged
merged 3 commits into from Dec 7, 2023
Merged

Add support for request body gzip Content-Encoding #2247

merged 3 commits into from Dec 7, 2023

Conversation

fbus
Copy link
Contributor

@fbus fbus commented Nov 27, 2023

When there is a gzip 'Content-Encoding' header, feign should create a GzipCompressingEntity to wrap the StringEntity / ByteArrayEntity.

This is a fix for this issue: #2245

@fbus
Copy link
Contributor Author

fbus commented Nov 27, 2023

I tried to follow the coding style.
I'm really not sure why there's so much code duplication between ApacheHttp5Client / AsyncApacheHttp5Client. They are very similar but AsyncApacheHttp5Client seems to be based on an older copy of ApacheHttp5Client.
I didn't try to solve this though, and just duplicated my fix

@velo velo merged commit 6f4226d into OpenFeign:master Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velo velo velo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbus @velo @fabienbuss