Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge using extension #78

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Merge using extension #78

merged 2 commits into from
Nov 9, 2023

Conversation

velo
Copy link
Member

@velo velo commented Nov 9, 2023

Proposal for addition for merge using syntax related to querydsl/querydsl#2520
Few notes:

  • This changes interfaces, japicmp-maven-plugin will complain
  • Merge using query works also with latest versions of H2 and PostgreSQL, however bumping versions results in other tests breaking
  • In case of Oracle it currently produces Caused by: java.sql.SQLSyntaxErrorException: ORA-00969: missing ON keyword. Reason being it doesn't put "as" between subquery and its alias, not sure how to fix nicely.

Copy of querydsl/querydsl#3625

@velo
Copy link
Member Author

velo commented Nov 9, 2023

@borgiiri I will hold merging this till I hear you ok with it

@borgiiri
Copy link
Contributor

borgiiri commented Nov 9, 2023

Thanks, if you want you can also merge this as is and I can provide updates as separate PR.
As of now the merge using syntax does work if you use queryFactory.merge(...).using(SQLExpressions.select(...).from(...).as(...)).on(...)...
I'm quite busy in the coming days, so will only manage to continue this properly next week.

@velo
Copy link
Member Author

velo commented Nov 9, 2023

Sweet, will merge as is then

@velo velo merged commit 441dc50 into querydsl-5.0.0 Nov 9, 2023
10 checks passed
@velo velo deleted the merge-using-extension branch November 9, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants