Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure project from code (api/PUT) #288

Closed
2 of 3 tasks
amberrignell opened this issue Aug 24, 2022 · 1 comment
Closed
2 of 3 tasks

Configure project from code (api/PUT) #288

amberrignell opened this issue Aug 24, 2022 · 1 comment
Assignees

Comments

@amberrignell
Copy link
Contributor

amberrignell commented Aug 24, 2022

User story

As a developer configuring a Lightning project and writing my jobs in my code editor, I want to configure and deploy my changes to my Lightning instance through the command line, so that I don't have to make the changes manually through the UI.

Details

Create an API endpoint which, given a project.yaml and/or some files, can configure a project on lightning.

Implementation notes

Release notes

User acceptance criteria

  • When I deploy a project which already exists in Lightning, it doesn't create a new one but rather updates the existing one.
  • If my lightning instance and my project as code have a job expression with the same id but different values, the lightning instance's job expression gets update with the new job expression.
  • When I deploy a project which is scheduled for deletion, I get an error. (moved to Consider blocking project update via API once its been marked for deletion #876 )
@amberrignell amberrignell self-assigned this Aug 24, 2022
@amberrignell amberrignell added the needs detail More detail is needed before development can start label Aug 24, 2022
@taylordowns2000 taylordowns2000 changed the title Configure a Lightning project through an API endpoint Configure project from code (api/PUT) Aug 28, 2022
@stuartc stuartc mentioned this issue May 12, 2023
11 tasks
@taylordowns2000 taylordowns2000 removed the needs detail More detail is needed before development can start label May 26, 2023
@taylordowns2000
Copy link
Member

taylordowns2000 commented Jun 13, 2023

@amberrignell , user acceptance testing

  1. update in place, yes
image
  1. rewriting job code, yes
image
  1. error when trying to deploy to project marked for deletion, not quite...
image

For this last one, let's discuss. It's a one-line change to make this throw an error, but I want to be double sure that this is the behaviour we want. See change here if we want it:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants