Update hostname, uri format in configuration-schema
#516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mtuchi
changed the title
postgresql, mysql, hivehostname format in configuration-schema
mtuchi
changed the title
hostname format in configuration-schema hostname, uri format in configuration-schema
| @@ -54,7 +54,7 @@ | |||
| "additionalProperties": true, | |||
| "required": [ | |||
| "host", | |||
| "port", | |||
| "database", | |||
There was a problem hiding this comment.
This looks out of scope - is it intended?
There was a problem hiding this comment.
It's kind related, There is an issue on docs for displaying only required properties in sample configuration. And hive was missing database in required properties
There was a problem hiding this comment.
That's fine - so long as it's deliberate and expected. It should really be flagged in the main PR description, but you've clarified it now :)
josephjclark
approved these changes
Apr 24, 2024
|
This is great @mtuchi, thanks. Please bump versions, push tags and merge and your leisure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the
Database URLto betype: stringand update the required propertiesRef #511
Review Checklist
dev only changes don't need a changeset.