Merge pull request #56 from OpenFn/55-undefined-log-message

Avoid displaying `undefined` value in `create` log message
OpenFn · Jan 28, 2022 · 45327de · 45327de
2 parents f94094f + 65cefea
commit 45327de
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/lib/Adaptor.js b/lib/Adaptor.js
@@ -322,7 +322,12 @@ function create(resourceType, data, options = {}, callback = false) {
       data: (0, _Utils.nestArray)(data, resourceType),
       ...requestConfig
     }).then(result => {
-      _Utils.Log.success(`Created ${resourceType}: ${result.headers.location}`);
+      const {
+        data
+      } = result;
+      const details = `with response ${JSON.stringify(data, null, 2)}`;
+
+      _Utils.Log.success(`Created ${resourceType} ${details}`);
 
       return (0, _Utils.handleResponse)(result, state, callback);
     });

diff --git a/src/Adaptor.js b/src/Adaptor.js
@@ -235,7 +235,10 @@ export function create(resourceType, data, options = {}, callback = false) {
       data: nestArray(data, resourceType),
       ...requestConfig,
     }).then(result => {
-      Log.success(`Created ${resourceType}: ${result.headers.location}`);
+      const { data } = result;
+      const details = `with response ${JSON.stringify(data, null, 2)}`;
+
+      Log.success(`Created ${resourceType} ${details}`);
       return handleResponse(result, state, callback);
     });
   };

diff --git a/test/integration.js b/test/integration.js
@@ -247,7 +247,7 @@ describe('Integration tests', () => {
       configuration: {
         username: 'admin',
         password: 'district',
-        hostUrl: 'https://play.dhis2.org/2.36.4',
+        hostUrl: 'https://play.dhis2.org/2.37.2',
       },
       data: {},
     };