Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ALLOW_DEMO_RESET" env variable, default FALSE #1720

Closed
taylordowns2000 opened this issue Feb 8, 2024 · 0 comments · Fixed by #1802
Closed

Add "ALLOW_DEMO_RESET" env variable, default FALSE #1720

taylordowns2000 opened this issue Feb 8, 2024 · 0 comments · Fixed by #1802
Assignees

Comments

@taylordowns2000
Copy link
Member

taylordowns2000 commented Feb 8, 2024

As far as "foot guns" go, this is a big one. I'd prefer it if most lightning instances could not be reset to a demo state with a single command.

  • Use the Vapor API
  • Make sure that if nothing gets set, this thing is false. (It's a special case when someone would actually want a "destroy everything" button... we happen to use it for our public sandbox which gets a nightly cleaning.)
  • Expect Lightning.Demo.reset_demo() throws an exception if someone attempts it without this ENV flag
  • Expect the mix task to throw an exception also
@taylordowns2000 taylordowns2000 changed the title Add "CAN_RESET_TO_DEMO" env variable, default FALSE Add "ALLOW_DEMO_RESET" env variable, default FALSE Feb 15, 2024
@taylordowns2000 taylordowns2000 self-assigned this Feb 26, 2024
taylordowns2000 added a commit that referenced this issue Feb 26, 2024
@taylordowns2000 taylordowns2000 mentioned this issue Feb 26, 2024
4 tasks
taylordowns2000 added a commit that referenced this issue Feb 27, 2024
* close #1720

* update deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant