Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github sync fails when trying to add specific repo and branch #1845

Closed
1 task
aleksa-krolls opened this issue Feb 29, 2024 · 3 comments · Fixed by #1846
Closed
1 task

Github sync fails when trying to add specific repo and branch #1845

aleksa-krolls opened this issue Feb 29, 2024 · 3 comments · Fixed by #1846
Assignees
Labels
bug Newly identified bug

Comments

@aleksa-krolls
Copy link
Member

aleksa-krolls commented Feb 29, 2024

Describe the bug A clear and concise description of what the bug is.
See video of the issue.

  1. I've created a Github connection and authorized openfn to access this water-aid repo (which is a private repo btw)
  2. Now when in Project Settings> Sync to Github page, the repository and branch I pick never save: https://app.openfn.org/projects/477af5c0-cd79-4fa9-a0f5-34fb28a20b3c/settings#vcs

Version number The version of Lightning you have seen the bug on.
v2.0.6 on app.openfn.org

I have reproduced this locally on main:

  • Yes
  • [ x] No

To Reproduce Steps to reproduce the behavior:
In [water aid australia project(https://app.openfn.org/projects/477af5c0-cd79-4fa9-a0f5-34fb28a20b3c/settings#vcs)...

  1. Go to Project Settings and create Github connection
  2. Authorize access to water-aid repo
  3. Try to then pick the water-aid repository and staging branch on this page --> watch it not save

Expected behavior
Github sync configuration should save :)

Additional context
This is a private repo... does that affect anything?

@aleksa-krolls aleksa-krolls added the bug Newly identified bug label Feb 29, 2024
Copy link

sentry-io bot commented Feb 29, 2024

Sentry Issue: LIGHTNING-A6

@taylordowns2000
Copy link
Member

@christad92 , @midigofrank , check out sentry here. looks like the files aren't available on app? (docker image/build issue maybe?)

@taylordowns2000
Copy link
Member

Reopening. Still not working. Something to do with @github_assets_dir Application.app_dir(:lightning, "priv/github") maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Newly identified bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants