Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select OpenFn -> Github by default when connecting to Github #1994

Closed
4 tasks done
midigofrank opened this issue Apr 17, 2024 · 0 comments · Fixed by #1998
Closed
4 tasks done

Select OpenFn -> Github by default when connecting to Github #1994

midigofrank opened this issue Apr 17, 2024 · 0 comments · Fixed by #1998
Assignees
@taylordowns2000 @midigofrank

Comments

@midigofrank
Copy link
Collaborator

midigofrank commented Apr 17, 2024 •
edited by taylordowns2000

Checklist

  • Make OpenFn -> GitHub the first option
  • Select OpenFn -> GitHub by default
  • If GitHub -> OpenFn is selected, make path_to_config required
  • Show warning message if user picks "GitHub to OpenFn"

Message for warning:

"Warning: You are choosing to overwrite your whole OpenFn project with whatever you have already built on GitHub. This is a destructive action—you won't be able to recover your current OpenFn workflows. Are you sure you want to do this?"
@midigofrank midigofrank self-assigned this Apr 17, 2024
taylordowns2000 added a commit that referenced this issue Apr 18, 2024
@taylordowns2000
change wording and order and validation for gh, fixes #1994
d53b21d
@taylordowns2000 taylordowns2000 self-assigned this Apr 18, 2024
@taylordowns2000 taylordowns2000 mentioned this issue Apr 18, 2024
Merged
4 tasks
taylordowns2000 added a commit that referenced this issue Apr 19, 2024
@taylordowns2000 @midigofrank
GitHub HotFix (#1998)
27bee8b 
* change wording and order and validation for gh, fixes #1994

* 2.4.1-pre for GH hotfix

* update CL

* double double default default

* Update project_repo_connection.ex

Co-authored-by: Midigo Frank <39288959+midigofrank@users.noreply.github.com>

* Update project_repo_connection.ex

Co-authored-by: Midigo Frank <39288959+midigofrank@users.noreply.github.com>

---------

Co-authored-by: Midigo Frank <39288959+midigofrank@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taylordowns2000 taylordowns2000

@midigofrank midigofrank

Labels
None yet
Projects
v2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GitHub HotFix OpenFn/lightning
2 participants
@taylordowns2000 @midigofrank