Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for the reviewer
RunOptions
struct in favour of aKeyword list
. It's much easier to define optional keys withKeyword
s.callback
calledget_run_option
which returns an empty list in the default implementation. These options are considered "extra". And therefore in order to get the run options, we create thedefault options
(the previous options) and merge with options from the implementation.Related issue
Paves way for: https://github.com/OpenFn/thunderbolt/issues/45
Review checklist
:owner
,:admin
,:editor
,:viewer
) have been implemented and tested