Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit worker run timeout #2015

Merged
merged 3 commits into from May 8, 2024
Merged

Limit worker run timeout #2015

merged 3 commits into from May 8, 2024

Conversation

midigofrank
Copy link
Collaborator

@midigofrank midigofrank commented Apr 23, 2024

Notes for the reviewer

  • Gets rid of RunOptions struct in favour of a Keyword list. It's much easier to define optional keys with Keywords.
  • Introduces a new callback called get_run_option which returns an empty list in the default implementation. These options are considered "extra". And therefore in order to get the run options, we create the default options (the previous options) and merge with options from the implementation.

Related issue

Paves way for: https://github.com/OpenFn/thunderbolt/issues/45

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies (:owner, :admin, :editor, :viewer) have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

@midigofrank midigofrank self-assigned this Apr 23, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (36fb5b6) to head (e11c262).

❗ Current head e11c262 differs from pull request most recent head e9b5ce9. Consider uploading reports for the commit e9b5ce9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
- Coverage   90.10%   90.05%   -0.05%     
==========================================
  Files         251      249       -2     
  Lines        8244     8225      -19     
==========================================
- Hits         7428     7407      -21     
- Misses        816      818       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@midigofrank midigofrank marked this pull request as ready for review April 24, 2024 09:26
@midigofrank midigofrank force-pushed the limit-worker-run-timeout branch 2 times, most recently from 40ca63a to e11c262 Compare April 30, 2024 07:50
@stuartc stuartc merged commit 56e48c8 into main May 8, 2024
6 checks passed
@stuartc stuartc deleted the limit-worker-run-timeout branch May 8, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants