Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user registration via API #2043

Closed
wants to merge 3 commits into from
Closed

Conversation

midigofrank
Copy link
Collaborator

@midigofrank midigofrank commented Apr 30, 2024

Validation Steps

curl -X POST \
  -H "Content-Type: application/json" \
  -d '{"user": {"first_name": "test", "last_name": "last", "email": "testemail@openfn.org", "password": "mypassword", "terms_accepted": true}}' \
  http://localhost:4000/api/users/register

Notes for the reviewer

  • Uses the same controller action for user registration.

Related issue

Fixes OpenFn/thunderbolt#125

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies (:owner, :admin, :editor, :viewer) have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

@midigofrank midigofrank self-assigned this Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (50e2efd) to head (7e7c794).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    OpenFn/lightning#2043      +/-   ##
==========================================
+ Coverage   90.04%   90.06%   +0.02%     
==========================================
  Files         249      249              
  Lines        8219     8226       +7     
==========================================
+ Hits         7401     7409       +8     
+ Misses        818      817       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@midigofrank midigofrank changed the title Add user registration via API Allow user registration via API Apr 30, 2024
@midigofrank
Copy link
Collaborator Author

Issue moved to thunderbolt

@midigofrank midigofrank closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant