Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block users from configuring failure alerts when the limiter returns error #2076

Merged
merged 2 commits into from May 13, 2024

Conversation

midigofrank
Copy link
Collaborator

@midigofrank midigofrank commented May 13, 2024

Notes for the reviewer

  • Moves the limit function to a new module so that it can be reused by the UI and during the run execution
  • Does not show the form when the limiter returns an error
  • It always shows Disabled if the limiter returns an error. So even if the user had enabled the alerts previously, it will still display as Disabled

Related issue

Fixes https://github.com/OpenFn/thunderbolt/issues/141

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies (:owner, :admin, :editor, :viewer) have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (cfae722) to head (1eba02a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2076   +/-   ##
=======================================
  Coverage   90.14%   90.15%           
=======================================
  Files         253      254    +1     
  Lines        8278     8285    +7     
=======================================
+ Hits         7462     7469    +7     
  Misses        816      816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@midigofrank midigofrank force-pushed the block-users-from-configuring-failure-alerts branch from eac08d3 to 1eba02a Compare May 13, 2024 08:35
@stuartc stuartc merged commit 4bb8d98 into main May 13, 2024
8 checks passed
@stuartc stuartc deleted the block-users-from-configuring-failure-alerts branch May 13, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants