Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just checking version import #165

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Just checking version import #165

merged 3 commits into from
Apr 5, 2023

Conversation

IAlibay
Copy link
Contributor

@IAlibay IAlibay commented Apr 5, 2023

In this PR:

  • Check version import in CI
  • fixes universal wheel

@IAlibay
Copy link
Contributor Author

IAlibay commented Apr 5, 2023

@mikemhenry the version installs as 0.0.0 - this seems weird? (https://github.com/OpenFreeEnergy/gufe/actions/runs/4621160585/jobs/8172233914?pr=165)

@IAlibay
Copy link
Contributor Author

IAlibay commented Apr 5, 2023

nevermind, this is a checkout depth issue

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (741d20b) 99.04% compared to head (7c5ca3b) 99.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          35       35           
  Lines        1683     1683           
=======================================
  Hits         1667     1667           
  Misses         16       16           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -43,9 +43,6 @@ license-files = ["LICENSE"]
[tool.setuptools.packages]
find = {namespaces = false}

[tool.distutils.bdist_wheel]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikemhenry - universal bdist_wheel entries are for pure Python projects that are both py2 and py3 compliant (you can see the effect when you build a wheel, it'll output "py2py3" in the name)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied what was in the setup.py, good catch! (I can't belive they still let people support python 2)

@IAlibay IAlibay marked this pull request as ready for review April 5, 2023 17:50
@mikemhenry
Copy link
Contributor

And yes, I have it setup to use 0.0.0 if I can't find tag info instead of error out, so this behavior is expected. A depth of 0 should be fine since our repo is small

@mikemhenry
Copy link
Contributor

Also @IAlibay would you mind doing this for openfe as well?

@IAlibay
Copy link
Contributor Author

IAlibay commented Apr 5, 2023

yup will do

@IAlibay IAlibay merged commit 545becd into main Apr 5, 2023
@IAlibay IAlibay deleted the checking-version branch April 5, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants