-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just checking version import #165
Conversation
@mikemhenry the version installs as |
nevermind, this is a checkout depth issue |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 35 35
Lines 1683 1683
=======================================
Hits 1667 1667
Misses 16 16 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -43,9 +43,6 @@ license-files = ["LICENSE"] | |||
[tool.setuptools.packages] | |||
find = {namespaces = false} | |||
|
|||
[tool.distutils.bdist_wheel] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemhenry - universal bdist_wheel entries are for pure Python projects that are both py2 and py3 compliant (you can see the effect when you build a wheel, it'll output "py2py3" in the name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied what was in the setup.py, good catch! (I can't belive they still let people support python 2)
And yes, I have it setup to use 0.0.0 if I can't find tag info instead of error out, so this behavior is expected. A depth of 0 should be fine since our repo is small |
Also @IAlibay would you mind doing this for openfe as well? |
yup will do |
In this PR: