Openfe issue 278 #183
Merged
Openfe issue 278 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to off tk #1563
related to off tk #1563
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 35 35
Lines 1684 1684
=======================================
Hits 1668 1668
Misses 16 16 ☔ View full report in Codecov by Sentry. |
IAlibay
previously requested changes
Apr 25, 2023
|
Even if this is fixed upstream, I think we should keep this test https://github.com/OpenFreeEnergy/gufe/pull/183/files#diff-5ec98522e7a8c553d2a8736b0bad178b7acf7182d2434480037c377fd26c2726R325 |
This reverts commit 812b7be.
v0.13.0 fixes a bug around aromaticity
richardjgowers
dismissed
IAlibay’s stale review
removed code changes, just updated fftk pin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to OpenFreeEnergy/openfe#278