Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proteincomponent: tweak conversions to/from openmm/rdkit #209

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

richardjgowers
Copy link
Contributor

helps with some nonstandard residues previously giving KeyError AROMATIC

will not affect serialised representations (i.e. keys) as these don't use this path

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (980b812) 99.09% compared to head (4d4b14c) 99.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          36       36           
  Lines        1771     1771           
=======================================
  Hits         1755     1755           
  Misses         16       16           
Impacted Files Coverage Δ
gufe/components/proteincomponent.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

helps with some nonstandard residues previously giving KeyError AROMATIC

will not affect serialised representations (i.e. keys) as these don't use this path
@richardjgowers richardjgowers force-pushed the fixup_nonstandard_proteincomponent branch from 5ab9ecc to 4d4b14c Compare July 18, 2023 14:55
@richardjgowers richardjgowers merged commit 8d9fb2e into main Jul 18, 2023
7 checks passed
@richardjgowers richardjgowers deleted the fixup_nonstandard_proteincomponent branch July 18, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant