Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network generators #42

Merged
merged 13 commits into from May 10, 2024
Merged

Network generators #42

merged 13 commits into from May 10, 2024

Conversation

RiesBen
Copy link
Contributor

@RiesBen RiesBen commented May 10, 2024

here, really separating out the generator refactoring.

@pep8speaks
Copy link

pep8speaks commented May 10, 2024

Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2:80: E501 line too long (92 > 79 characters)
Line 7:80: E501 line too long (95 > 79 characters)
Line 11:80: E501 line too long (99 > 79 characters)

Line 137:80: E501 line too long (88 > 79 characters)
Line 174:9: E731 do not assign a lambda expression, use a def
Line 196:17: E731 do not assign a lambda expression, use a def
Line 283:13: E731 do not assign a lambda expression, use a def
Line 294:17: E731 do not assign a lambda expression, use a def
Line 296:17: E731 do not assign a lambda expression, use a def
Line 296:38: E713 test for membership should be 'not in'
Line 300:80: E501 line too long (80 > 79 characters)

Line 38:13: E122 continuation line missing indentation or outdented
Line 38:80: E501 line too long (80 > 79 characters)

Line 28:80: E501 line too long (87 > 79 characters)
Line 76:80: E501 line too long (82 > 79 characters)

Line 62:9: E303 too many blank lines (2)

Line 59:9: E125 continuation line with same indent as next logical line

Line 26:1: E302 expected 2 blank lines, found 1
Line 29:18: E122 continuation line missing indentation or outdented
Line 124:80: E501 line too long (82 > 79 characters)
Line 141:80: E501 line too long (81 > 79 characters)
Line 146:80: E501 line too long (80 > 79 characters)

Line 46:80: E501 line too long (80 > 79 characters)
Line 56:80: E501 line too long (81 > 79 characters)
Line 64:9: E125 continuation line with same indent as next logical line

Line 49:9: E125 continuation line with same indent as next logical line

Line 41:9: E125 continuation line with same indent as next logical line

Line 36:80: E501 line too long (81 > 79 characters)
Line 44:9: E125 continuation line with same indent as next logical line
Line 75:36: E741 ambiguous variable name 'l'

Line 40:80: E501 line too long (81 > 79 characters)
Line 66:9: E125 continuation line with same indent as next logical line

Line 41:80: E501 line too long (81 > 79 characters)
Line 51:9: E125 continuation line with same indent as next logical line
Line 100:40: E741 ambiguous variable name 'l'

Line 34:80: E501 line too long (81 > 79 characters)

Line 9:80: E501 line too long (100 > 79 characters)

Line 8:80: E501 line too long (107 > 79 characters)

Line 11:80: E501 line too long (106 > 79 characters)
Line 38:80: E501 line too long (106 > 79 characters)

Line 7:80: E501 line too long (81 > 79 characters)
Line 8:5: E128 continuation line under-indented for visual indent
Line 9:5: E128 continuation line under-indented for visual indent
Line 10:5: E128 continuation line under-indented for visual indent

Line 11:80: E501 line too long (81 > 79 characters)
Line 78:80: E501 line too long (81 > 79 characters)

Line 85:69: E251 unexpected spaces around keyword / parameter equals
Line 86:80: E501 line too long (80 > 79 characters)

Line 12:80: E501 line too long (81 > 79 characters)
Line 92:80: E501 line too long (81 > 79 characters)

Line 10:80: E501 line too long (106 > 79 characters)
Line 27:80: E501 line too long (95 > 79 characters)
Line 30:80: E501 line too long (94 > 79 characters)

Comment last updated at 2024-05-10 18:54:02 UTC

@RiesBen RiesBen merged commit 747503d into main May 10, 2024
4 checks passed
@RiesBen RiesBen deleted the network_generators branch May 10, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants