Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - adding intermediate generator to konnektor #51

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

RiesBen
Copy link
Contributor

@RiesBen RiesBen commented Jun 21, 2024

This is a long term PR for adding Intermediate Generators to Konnektor.

more will be here soon

@RiesBen RiesBen added enhancement New feature or request Konnektor labels Jun 21, 2024
@pep8speaks
Copy link

pep8speaks commented Jun 21, 2024

Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 11:1: E265 block comment should start with '# '
Line 19:1: E302 expected 2 blank lines, found 1
Line 20:80: E501 line too long (84 > 79 characters)
Line 23:41: W291 trailing whitespace
Line 25:80: E501 line too long (96 > 79 characters)
Line 30:80: E501 line too long (107 > 79 characters)
Line 34:80: E501 line too long (94 > 79 characters)
Line 36:1: W293 blank line contains whitespace
Line 46:80: E501 line too long (94 > 79 characters)
Line 47:1: W293 blank line contains whitespace
Line 48:1: E302 expected 2 blank lines, found 1
Line 49:52: E231 missing whitespace after ':'
Line 49:56: E252 missing whitespace around parameter equals
Line 49:57: E252 missing whitespace around parameter equals
Line 49:75: E231 missing whitespace after ':'
Line 49:79: E252 missing whitespace around parameter equals
Line 49:80: E252 missing whitespace around parameter equals
Line 49:80: E501 line too long (81 > 79 characters)
Line 50:40: E252 missing whitespace around parameter equals
Line 50:67: E231 missing whitespace after ':'
Line 50:72: E252 missing whitespace around parameter equals
Line 50:73: E252 missing whitespace around parameter equals
Line 51:31: E231 missing whitespace after ':'
Line 51:35: E252 missing whitespace around parameter equals
Line 51:36: E252 missing whitespace around parameter equals
Line 51:47: E231 missing whitespace after ':'
Line 51:51: E252 missing whitespace around parameter equals
Line 51:52: E252 missing whitespace around parameter equals
Line 51:73: E231 missing whitespace after ':'
Line 51:77: E252 missing whitespace around parameter equals
Line 51:78: E252 missing whitespace around parameter equals
Line 51:80: E501 line too long (81 > 79 characters)
Line 52:36: E231 missing whitespace after ','
Line 53:47: E231 missing whitespace after ':'
Line 53:51: E252 missing whitespace around parameter equals
Line 53:54: E231 missing whitespace after ','
Line 53:73: E231 missing whitespace after ':'
Line 53:79: E252 missing whitespace around parameter equals
Line 53:80: E501 line too long (121 > 79 characters)
Line 53:109: E231 missing whitespace after ':'
Line 53:115: E252 missing whitespace around parameter equals
Line 59:21: E225 missing whitespace around operator
Line 62:34: E225 missing whitespace around operator
Line 63:31: E225 missing whitespace around operator
Line 67:37: E225 missing whitespace around operator
Line 69:80: E501 line too long (96 > 79 characters)
Line 79:80: E501 line too long (81 > 79 characters)
Line 86:80: E501 line too long (80 > 79 characters)
Line 87:80: E501 line too long (88 > 79 characters)
Line 88:80: E501 line too long (114 > 79 characters)
Line 89:80: E501 line too long (98 > 79 characters)
Line 90:80: E501 line too long (88 > 79 characters)
Line 91:80: E501 line too long (86 > 79 characters)
Line 98:80: E501 line too long (84 > 79 characters)
Line 99:80: E501 line too long (81 > 79 characters)
Line 100:80: E501 line too long (81 > 79 characters)
Line 104:80: E501 line too long (80 > 79 characters)
Line 105:80: E501 line too long (80 > 79 characters)
Line 106:80: E501 line too long (83 > 79 characters)
Line 107:80: E501 line too long (103 > 79 characters)
Line 108:80: E501 line too long (92 > 79 characters)
Line 109:80: E501 line too long (97 > 79 characters)
Line 122:80: E501 line too long (94 > 79 characters)

Comment last updated at 2024-08-01 13:24:10 UTC

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.

Project coverage is 87.06%. Comparing base (6a043ca) to head (8a5c602).
Report is 1 commits behind head on main.

Files Patch % Lines
...ork_tools/intermediate_generators/intermediator.py 0.00% 60 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   91.10%   87.06%   -4.05%     
==========================================
  Files          46       47       +1     
  Lines        1293     1353      +60     
==========================================
  Hits         1178     1178              
- Misses        115      175      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Konnektor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants