Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage properly setting residue names when building form SDF #463

Open
IAlibay opened this issue Jun 19, 2023 · 3 comments
Open

Encourage properly setting residue names when building form SDF #463

IAlibay opened this issue Jun 19, 2023 · 3 comments

Comments

@IAlibay
Copy link
Contributor

IAlibay commented Jun 19, 2023

The UNK residue is rather meaningless. Is there a way we could enforce (at the SmallMoleculeComponent) both a warning & some kind of convenience method to override the residue name?

@richardjgowers
Copy link
Contributor

richardjgowers commented Jun 19, 2023 via email

@IAlibay
Copy link
Contributor Author

IAlibay commented Jun 19, 2023

@richardjgowers it's a "partially us" problem, as you say SDFs don't set Monomerinfo, so we don't propagate the residue name through (so OpenFF / OpenMM just set it to UNK). What I'm saying here is that we should encourage users to propagate this information along. It's useful information that should be written into tthe system and we're not doing anything about it.

Our users are going to be very confused when they see the residue UNK and wonder why on earth that happened.

@IAlibay
Copy link
Contributor Author

IAlibay commented Jun 9, 2024

Related: OpenFreeEnergy/gufe#327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants