-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force no oechem #479
Merged
Merged
Force no oechem #479
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# This code is part of OpenFE and is licensed under the MIT license. | ||
# For details, see https://github.com/OpenFreeEnergy/openfe | ||
from openfe.utils import without_oechem_backend | ||
from openff.toolkit import GLOBAL_TOOLKIT_REGISTRY, OpenEyeToolkitWrapper | ||
|
||
|
||
def test_remove_oechem(): | ||
original_tks = GLOBAL_TOOLKIT_REGISTRY.registered_toolkits | ||
original_n_tks = len(GLOBAL_TOOLKIT_REGISTRY.registered_toolkits) | ||
|
||
with without_oechem_backend(): | ||
for tk in GLOBAL_TOOLKIT_REGISTRY.registered_toolkits: | ||
assert not isinstance(tk, OpenEyeToolkitWrapper) | ||
assert len(GLOBAL_TOOLKIT_REGISTRY.registered_toolkits) == original_n_tks | ||
for ref_tk, tk in zip(original_tks, | ||
GLOBAL_TOOLKIT_REGISTRY.registered_toolkits): | ||
assert isinstance(tk, type(ref_tk)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# This code is part of OpenFE and is licensed under the MIT license. | ||
# For details, see https://github.com/OpenFreeEnergy/openfe | ||
from openff.toolkit import GLOBAL_TOOLKIT_REGISTRY, OpenEyeToolkitWrapper | ||
from openff.toolkit.utils.toolkit_registry import ToolkitUnavailableException | ||
|
||
from contextlib import contextmanager | ||
|
||
|
||
@contextmanager | ||
def without_oechem_backend(): | ||
"""For temporarily removing oechem from openff's toolkit registry""" | ||
current_toolkits = [type(tk) | ||
for tk in GLOBAL_TOOLKIT_REGISTRY.registered_toolkits] | ||
|
||
try: | ||
GLOBAL_TOOLKIT_REGISTRY.deregister_toolkit(OpenEyeToolkitWrapper()) | ||
except ToolkitUnavailableException: | ||
pass | ||
|
||
try: | ||
yield None | ||
finally: | ||
# this is order dependent; we want to prepend OEChem back to first | ||
while GLOBAL_TOOLKIT_REGISTRY.registered_toolkits: | ||
GLOBAL_TOOLKIT_REGISTRY.deregister_toolkit( | ||
GLOBAL_TOOLKIT_REGISTRY.registered_toolkits[0]) | ||
for tk in current_toolkits: | ||
GLOBAL_TOOLKIT_REGISTRY.register_toolkit(tk) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we might need to review this a bit later, I suspect we'll run into trouble when we start offering folks the ability to choose what charge derivation method they can have (for example if they want elf charges)