Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build osx x86 installers #865

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Build osx x86 installers #865

merged 2 commits into from
Jun 10, 2024

Conversation

mikemhenry
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

@mikemhenry
Copy link
Contributor Author

With the changes to macos-latest we built osx-arm64 but not osx-x86 single file installers for the openfe 1.0.1 release. This PR fixes that. It will be tested by running the workflow manually in the web ui.

@mikemhenry
Copy link
Contributor Author

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (48dcbb2) to head (bde3645).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
- Coverage   94.08%   92.27%   -1.81%     
==========================================
  Files         134      134              
  Lines        9790     9790              
==========================================
- Hits         9211     9034     -177     
- Misses        579      756     +177     
Flag Coverage Δ
fast-tests 92.27% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Contributor Author

It worked! Next release will not require manually upload of the osx-64 installer

@mikemhenry mikemhenry merged commit 4c9d32a into main Jun 10, 2024
15 checks passed
@mikemhenry mikemhenry deleted the build_osx-x86-installers branch June 10, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants