Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add knative prefix back to the annotation key #310

Closed
benjaminhuo opened this issue Jun 21, 2022 · 3 comments · Fixed by #311 or #370
Closed

Add knative prefix back to the annotation key #310

benjaminhuo opened this issue Jun 21, 2022 · 3 comments · Fixed by #311 or #370
Assignees
Labels
enhancement New feature or request

Comments

@benjaminhuo
Copy link
Member

benjaminhuo commented Jun 21, 2022

Description
Currently, openfunction support adding knative annotations but without knative prefix

image

We should support the original annotation key style with knative prefix like autoscaling.knative.dev/min-scale: "3"

Additional context
https://knative.dev/docs/serving/autoscaling/scale-bounds/#lower-bound

@benjaminhuo benjaminhuo added the enhancement New feature or request label Jun 21, 2022
@benjaminhuo benjaminhuo linked a pull request Jun 22, 2022 that will close this issue
@Yu-xiaoguang
Copy link

Is this method available in version 0.7.0

@benjaminhuo
Copy link
Member Author

@wrongerror We need to make changes to the knative params as we've discussed before in v0.8.0

@wrongerror
Copy link
Member

@wrongerror We need to make changes to the knative params as we've discussed before in v0.8.0

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
4 participants