-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a helm chart for openfunction and its dependencies #1
Conversation
targetPort: https | ||
type: ClusterIP | ||
webhookServerCert: | ||
tlsCrt: "LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUQvVENDQXVXZ0F3SUJBZ0lVQnV6QmJ6WDloSHlNL0tCNFpveFBhRmxkNWlvd0RRWUpLb1pJaHZjTkFRRUwKQlFBd0tqRW9NQ1lHQTFVRUF3d2ZZMkV0YjNCbGJtWjFibU4wYVc5dUxYZGxZbWh2YjJzdGMyVnlkbWxqWlRBZQpGdzB5TWpBME1EY3dNelV3TURaYUZ3MHpNakEwTURRd016VXdNRFphTUNjeEpUQWpCZ05WQkFNTUhHOXdaVzVtCmRXNWpkR2x2YmkxM1pXSm9iMjlyTFhObGNuWnBZMlV3Z2dFaU1BMEdDU3FHU0liM0RRRUJBUVVBQTRJQkR3QXcKZ2dFS0FvSUJBUURIK3BWZ1VKajJqbnNuZE03ay9VVFJwaWUwZHdWSHNYV2VOV0hwZEtQN2NXZVZqVlRLZHB5OApQdjBaQ3FjTlppQXlTUTNMcWJ0ejNLc0VUR3pxT091cDRyWUhTSDRMamJzSUtObGVZN0lmQkVkdFZ1Nlc0NjBPClkySVEvYmNWNU00R2xOb0RNdXd0azNHWGlsK3hNQkx0NUNFeHg5VGNXTmxrZzFrOFFlYWh6UUpxakJwNTFkTU8KSXprQVF4SGdmaUV3WXZPdjg4SmxGdDJvQkh1RHpCYWVzRnFlRTA3ck5BT3NnQmgvNEJXMmxva1pkODY3YnZPSgp4MjUybk9CbWxtWEFieG9ldGtHRlEzZnM4b0VaeWVCS0haWXhVYmVxSG9xaUlxaGFrZEUyajFjTVc4S1FEK3ZSCmFFMnZKMWlEc2lHQjQ5cENtMGhDL0lHeFVwM2I3SFBOQWdNQkFBR2pnZ0VjTUlJQkdEQUpCZ05WSFJNRUFqQUEKTUFzR0ExVWREd1FFQXdJRjREQWRCZ05WSFNVRUZqQVVCZ2dyQmdFRkJRY0RBZ1lJS3dZQkJRVUhBd0V3Z2Q0RwpBMVVkRVFTQjFqQ0IwNEljYjNCbGJtWjFibU4wYVc5dUxYZGxZbWh2YjJzdGMyVnlkbWxqWllJcGIzQmxibVoxCmJtTjBhVzl1TFhkbFltaHZiMnN0YzJWeWRtbGpaUzV2Y0dWdVpuVnVZM1JwYjI2Q0xXOXdaVzVtZFc1amRHbHYKYmkxM1pXSm9iMjlyTFhObGNuWnBZMlV1YjNCbGJtWjFibU4wYVc5dUxuTjJZNEk3YjNCbGJtWjFibU4wYVc5dQpMWGRsWW1odmIyc3RjMlZ5ZG1salpTNXZjR1Z1Wm5WdVkzUnBiMjR1YzNaakxtTnNkWE4wWlhJdWJHOWpZV3lDCkhHOXdaVzVtZFc1amRHbHZiaTEzWldKb2IyOXJMWE5sY25acFkyVXdEUVlKS29aSWh2Y05BUUVMQlFBRGdnRUIKQUkxQnVhSlM5WUxHOUlYSU0rSUVYU3p5bW80N3BpVzkrQS8wQUtrK0RnVUpPMEZURDJqZEtQNkZ5WTB2VDJxRQo5OTNxZE5XZXdSdHQ4N1ZxUmQvVHNRQWVnMHhZZWxURUVOb0RBZjYzSEIzWEY2b0JmUHRkaU1XMGgxSnYwendsCjdRN2cxZTZNVDBaN0Zxb21ZQ1VFOC8zTG1oMHhWcTNHL1cvS0Fnd1JCQkZlekl4WlM5NVg3UkJsVkdoSkI5WnoKTmY3cmtEVDhwOFpnZ3JjZUE4RHNYM3lPMEF4cGVuS0RVRUNQR1doQVVESG1pVmFURURoZU1Vd3pyZCtIWUdqYwpnenR2Y0RXMGJSWkVJWDJsQUZDWHFESUhPNGRiODNxT2FFdHh2SlhyY1NvdEgvUnVmV1p0RWc0bjhqN0E0L0c5CjVqWjhVSTE4bXFoM1RmNnpzd0lhQUk4PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This certificate is only valid when openfunction is deployed in openfunction
namespace, how to deploy openfunction to another namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme.md documentation already states kubectl create ns openfunction
before install. helm automatically generates the certificate and modifies the corresponding crd and template files is a better way, but there are some issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support deploying to different ns is good, but it's not as urgent as the notification manager.
Notification manager is integrating with kubesphere and is installed to kubesphere-monitoring-system.
But users can also use it without kubesphere and then it might be installed to another different ns.
Installing OpenFunction to a different ns than openfunction is not as urgent as nm.
But we can create an issue if it's not included in this PR @wrongerror
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will create an issue about installing to different namespace. The reason for the problem is that the CRD requires the caBundle field for conversion, but crd itself does not support being rendered by the template. I've discussed this a lot with @tpiperatgod, I'm inclined to create a post-install
job to patch, if needed I think it can be done soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can take a look at how wanjun solved a problem like this: kubesphere/notification-manager#141
Signed-off-by: wrongerror <wangyifei@kubesphere.io>
Add a helm chart for openfunction and its dependencies that do not officially support helm deployments, currently it only supports kubeVersion 1.20+
Signed-off-by: wrongerror wangyifei@kubesphere.io