Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine declarative test cases into one test case #60

Merged
merged 5 commits into from
Aug 6, 2022

Conversation

lizzzcai
Copy link
Member

@lizzzcai lizzzcai commented Aug 6, 2022

Signed-off-by: Lize Cai lize.cai@sap.com

The current test/declarative has many test cases which are overlapped with each other.
This PR refine the test cases and merged them into one.

Signed-off-by: Lize Cai <lize.cai@sap.com>
Signed-off-by: Lize Cai <lize.cai@sap.com>
Signed-off-by: Lize Cai <lize.cai@sap.com>
@lizzzcai
Copy link
Member Author

lizzzcai commented Aug 6, 2022

The last commit in ff-go passed the tests (2 weeks ago), however, now is not working, even some existing tests which I didn't modify in this PR. I doubt that there are some issues in the main pipeline. @tpiperatgod do you have any idea? as I saw the dapr 1.8.3 upgrade PR was failed as well.

@benjaminhuo
Copy link
Member

Looks like in skywalking test, the pod is not in ready state for 30m

image

@lizzzcai
Copy link
Member Author

lizzzcai commented Aug 6, 2022

I found follow error in the function container:

❯ k logs sync-http-variables http -p
go: downloading github.com/cloudevents/sdk-go/v2 v2.4.1
go: downloading github.com/fatih/structs v1.1.0
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/SkyAPM/go2sky v1.4.1
go: downloading k8s.io/klog/v2 v2.30.0
go: downloading github.com/dapr/go-sdk v1.5.0
go: downloading github.com/google/uuid v1.3.0
go: downloading github.com/gorilla/mux v1.8.0
go: downloading skywalking.apache.org/repo/goapi v0.0.0-20220401015832-2c9eee9481eb
go: downloading github.com/dapr/dapr v1.8.1
go: downloading github.com/golang/protobuf v1.5.2
go: downloading github.com/pkg/errors v0.9.1
go: downloading google.golang.org/grpc v1.47.0
go: downloading github.com/go-logr/logr v1.2.3
go: downloading google.golang.org/protobuf v1.28.0
go: downloading go.uber.org/zap v1.21.0
go: downloading github.com/json-iterator/go v1.1.12
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading go.uber.org/atomic v1.9.0
go: downloading go.uber.org/multierr v1.7.0
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
/go/pkg/mod/github.com/dapr/go-sdk@v1.5.0/client/invoke.go:24:2: git init --bare in /go/pkg/mod/cache/vcs/f1f7f5699cc2a1eb340b65e04a580ccd22fcf094fae689e1eb8d44c8863a294a: exec: "git": executable file not found in $PATH
/go/pkg/mod/github.com/dapr/go-sdk@v1.5.0/client/actor.go:25:2: git init --bare in /go/pkg/mod/cache/vcs/f1f7f5699cc2a1eb340b65e04a580ccd22fcf094fae689e1eb8d44c8863a294a: exec: "git": executable file not found in $PATH
/go/pkg/mod/skywalking.apache.org/repo/goapi@v0.0.0-20220401015832-2c9eee9481eb/collect/language/agent/v3/BrowserPerf_grpc.pb.go:7:2: git init --bare in /go/pkg/mod/cache/vcs/6bc32f050d801af642e55338f0b2959a44689c94c534a4510e457234d980af67: exec: "git": executable file not found in $PATH
/go/pkg/mod/skywalking.apache.org/repo/goapi@v0.0.0-20220401015832-2c9eee9481eb/collect/language/agent/v3/BrowserPerf_grpc.pb.go:8:2: git init --bare in /go/pkg/mod/cache/vcs/6bc32f050d801af642e55338f0b2959a44689c94c534a4510e457234d980af67: exec: "git": executable file not found in $PATH
/go/pkg/mod/github.com/!sky!a!p!m/go2sky@v1.4.1/reporter/grpc.go:30:2: git init --bare in /go/pkg/mod/cache/vcs/6bc32f050d801af642e55338f0b2959a44689c94c534a4510e457234d980af67: exec: "git": executable file not found in $PATH
/go/pkg/mod/github.com/!sky!a!p!m/go2sky@v1.4.1/reporter/grpc.go:31:2: git init --bare in /go/pkg/mod/cache/vcs/6bc32f050d801af642e55338f0b2959a44689c94c534a4510e457234d980af67: exec: "git": executable file not found in $PATH
/go/pkg/mod/github.com/dapr/go-sdk@v1.5.0/client/client.go:30:2: git init --bare in /go/pkg/mod/cache/vcs/6bc32f050d801af642e55338f0b2959a44689c94c534a4510e457234d980af67: exec: "git": executable file not found in $PATH
/go/pkg/mod/github.com/dapr/go-sdk@v1.5.0/client/client.go:31:2: git init --bare in /go/pkg/mod/cache/vcs/6bc32f050d801af642e55338f0b2959a44689c94c534a4510e457234d980af67: exec: "git": executable file not found in $PATH
/go/pkg/mod/skywalking.apache.org/repo/goapi@v0.0.0-20220401015832-2c9eee9481eb/collect/language/agent/v3/BrowserPerf_grpc.pb.go:9:2: git init --bare in /go/pkg/mod/cache/vcs/6bc32f050d801af642e55338f0b2959a44689c94c534a4510e457234d980af67: exec: "git": executable file not found in $PATH
runtime/async/fakedaprserver.go:27:2: git init --bare in /go/pkg/mod/cache/vcs/6bc32f050d801af642e55338f0b2959a44689c94c534a4510e457234d980af67: exec: "git": executable file not found in $PATH
/go/pkg/mod/skywalking.apache.org/repo/goapi@v0.0.0-20220401015832-2c9eee9481eb/collect/common/v3/Common.pb.go:27:2: git init --bare in /go/pkg/mod/cache/vcs/a6c5d6b8734f41936247415390043c979295646fadef73c39eedc1735cd0fef4: exec: "git": executable file not found in $PATH
/go/pkg/mod/skywalking.apache.org/repo/goapi@v0.0.0-20220401015832-2c9eee9481eb/collect/common/v3/Common.pb.go:28:2: git init --bare in /go/pkg/mod/cache/vcs/a6c5d6b8734f41936247415390043c979295646fadef73c39eedc1735cd0fef4: exec: "git": executable file not found in $PATH
/go/pkg/mod/github.com/golang/protobuf@v1.5.2/ptypes/any/any.pb.go:9:2: git init --bare in /go/pkg/mod/cache/vcs/a6c5d6b8734f41936247415390043c979295646fadef73c39eedc1735cd0fef4: exec: "git": executable file not found in $PATH
/go/pkg/mod/github.com/golang/protobuf@v1.5.2/ptypes/duration/duration.pb.go:9:2: git init --bare in /go/pkg/mod/cache/vcs/a6c5d6b8734f41936247415390043c979295646fadef73c39eedc1735cd0fef4: exec: "git": executable file not found in $PATH
/go/pkg/mod/github.com/dapr/go-sdk@v1.5.0/client/client.go:32:2: git init --bare in /go/pkg/mod/cache/vcs/a6c5d6b8734f41936247415390043c979295646fadef73c39eedc1735cd0fef4: exec: "git": executable file not found in $PATH

Signed-off-by: Lize Cai <lize.cai@sap.com>
Signed-off-by: Lize Cai <lize.cai@sap.com>
@benjaminhuo benjaminhuo merged commit da4e2ca into OpenFunction:main Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants