Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style consistency #52

Open
Raymonf opened this issue Aug 27, 2020 · 1 comment
Open

Code style consistency #52

Raymonf opened this issue Aug 27, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@Raymonf
Copy link
Collaborator

Raymonf commented Aug 27, 2020

When I was making a clang-format config, I found that we had some issues with the DEBUGLOG macro. For example, things would be reformatted like this:

DEBUGLOG(
    std::cout << "P_CL2FE_REQ_PC_ENTER:" << std::endl;
    std::cout << "\tID: " << U16toU8(enter->szID) << std::endl;
    std::cout << "\tSerial: " << enter->iEnterSerialKey << std::endl;
    std::cout << "\tTemp: " << enter->iTempValue << std::endl;
    std::cout << "\tPC_UID: " << plr.PCStyle.iPC_UID << std::endl;)

So, I'm just making this issue as we need to eventually figure out a consistent code style and probably change up how DEBUGLOG works.

@CakeLancelot
Copy link
Member

Partially addressed in #54

@CakeLancelot CakeLancelot added the enhancement New feature or request label Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants