Revert "vpgtle: updated erroneous mhd raw data" #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpgtle: updated erroneous mhd raw data
The order in which the flags appear after g++ matters. The "compile" flags should go before the source file, the linking flags should go after, so you cannot combine them. Maybe the combined blurb was working with older versions of g++ and/or ROOT, but with g++ 9 and ROOT 6 it seems necessary to keep the compile flags and linking flags separate.
This reverts commit 0b3c860.
|
I think we must cleanup the repository, too bad for the (few) users who update frequently. The master branch is anyway a mess with files both tracked with git-lfs and git. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0b3c860.
This commit remove LFS pointers to binary files. So I revert the commit.
It's not perfect because the binariy files still are saved in Github's history but the solution to prevent this is to use a rebase and lead to conflict for users.