Phs source fixed segmentation fault (#328) #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbaudier
force-pushed
the
phsSourceCodeEnhancements_merge_test
branch
from
c7174a0
to
8bf79cb
Compare
|
The output of the test is empty @GitFuchs |
Fixed segmentation faults due to wrong variable type when passing from python to cpp. Was double, should be float * Enforce correct data type on python side (in case different data types in root file or delivered via uproot * restructured data transfer from python to cpp * minor adjustments * added method to rotate the phase space source in addition to movement required by treatment plan for treatment plan phs source * fixed wrongly initialized value for entry_start for multithreaded mode * fixed initialization for multithreading of phs source * Update phspsources.py In multithreading mode entry_start needs to be an array containing one entry for every thread. If it is not created by the user, create a entry_start array with the correct number of start entries all entries are spaced by the ceil(number of particles/thread)+1 * added improved initialization of starting values for phase space files and sources in multi threading * Improved phase space source documentation --------- Co-authored-by: Thomas BAUDIER <thomas.baudier@creatis.insa-lyon.fr>
tbaudier
force-pushed
the
phsSourceCodeEnhancements_merge_test
branch
from
c218fc8
to
b792627
Compare
|
Hello Hermann, Thank you for the bug fix. I integrated inside that PR and rebase everything on master. Unfortunately, the test test019_linac_elekta_versa_with_mlc_phsp_source.py does not work because inside the phsp used by that test, the PDGCode and Weight keys are not present, they are not necessary for the test. Do you have a solution? Thank you |
|
Hi Thomas, the mentioned tests work again. Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squash of https://github.com/OpenGATE/opengate/pull/328/files