Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of map rendering in collections #2

Open
mirtoto opened this issue Dec 21, 2020 · 3 comments
Open

Order of map rendering in collections #2

mirtoto opened this issue Dec 21, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@mirtoto
Copy link

mirtoto commented Dec 21, 2020

Hi Joe,

I have maps in a few collections and one of the map contain shape of the town. When I try to show collection with this shape of the town sometimes its covers other shapes from others maps. In my opinion it happens because of lack of priority attribute connected with map. Actually I workaround this behavior by removing map with shape of the town and adding new map because it seems that the newest added map is rendering as the first one when collection is rendering.

This page (from issue #1) show this problem perfectly - all circles are "under" shape of the town. I can't choose in which order maps are rendering. I can only use workaround described before.

The simplest method to resolve this problem is adding priority attribute to the maps and maps in collections should be render in order of these attributes.

Mirek

@morehawes morehawes added the enhancement New feature or request label Dec 21, 2020
@morehawes
Copy link
Collaborator

Hi Mirek,

Thanks for raising this, I will give some thought on how to go about implementing this as this is something I cam aware of. Depending on the amount of work required it may be a while until I am able to get round to this though.

One easy(ish) solution may be to specify a Map priority through the Shortcode, something like this:

[Waymark collection_id="123" map_priority="456,789,101"]

You wouldn't necessarily need to specify all Map IDs like this, just the ones you want to appear "on top". I can see that this could easily get unmanageable when dealing with lots of Maps though, so it's not ideal.

Let me know if you have any thoughts.

Cheers,

Joe

@mirtoto
Copy link
Author

mirtoto commented Dec 22, 2020

Hi Joe,

Thanks for response. I am thinking about adding something like on below image:
image

But I also understand that implement options with UI take time and much easier is implement the same as parameter of shortcode.

In my case your solution via shortcode will work. I have one map with shape of the town which I want to put always on background, next map with circles and order of other maps doesn't matter for me so much. As long as I can put on the list maps in order of rendering, i.e. [id of map with shape of town],[map1],[map2],[rest id are optional] such parameter will be useful.

Mirek

@morehawes
Copy link
Collaborator

Thanks for the extra detail and for your mockup. This will require some thought, as Maps can be in multiple Collections and so may need multiple priorities, making the UI a bit more complex.

If the Shortcode solution would work then perhaps this is the way to go for now. I'll have a think on this.

Cheers,

Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants