Resolvable securities #1711
Merged
Resolvable securities #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide means to resolve securities more easily Add `ResolvableSecurityTrade` implemented by `SecurityTrade` Change `GenericSecurityTrade` to be a `SecuritizedProductTrade` Tidy interfaces to avoid unnecessary inheritance Potential for source incompatibilities if impl security interfaces
jodastephen
force-pushed
the
topic/resolve-target
branch
from
99832c9
to
457067c
Compare
cjkent
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide means to resolve securities more easily
Add
ResolvableSecurityTradeimplemented bySecurityTradeChange
GenericSecurityTradeto be aSecuritizedProductTradeTidy interfaces to avoid unnecessary inheritance
Potential for source incompatibilities if impl security interfaces