Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ETD CSV parser #1556
Conversation
jodastephen
assigned
brianweller89
Sep 11, 2017
jodastephen
requested a review
from
brianweller89
Sep 11, 2017
jodastephen
added
the
Type:Enhancement
label
Sep 12, 2017
jodastephen
added some commits
Sep 7, 2017
| */ | ||
| public static int parseInteger(String str) { | ||
| return Integer.parseInt(str); | ||
| } |
This comment has been minimized.
This comment has been minimized.
brianweller89
Sep 14, 2017
Contributor
Is this method adding any value? Calling Integer.parseInt() directly seems good enough
This comment has been minimized.
This comment has been minimized.
jodastephen
Sep 15, 2017
Member
I'm assuming that we may add additional error handling or format handling later. With doubles in other projects we have supported (20) to mean -20.
This comment has been minimized.
This comment has been minimized.
| * <p> | ||
| * The following standard columns are supported:<br /> | ||
| * <ul> | ||
| * <li>The 'Strata Position Type' column is option, and defines the instrument type, |
This comment has been minimized.
This comment has been minimized.
| * If that column is not found, the 'Long Quantity' and 'Short Quantity' columns will be used instead. | ||
| * <p> | ||
| * The single 'Expiry' column will normally just be set. | ||
| * Flex futures will also set the 'Expiry Day', 'Settlement Type' and 'Exercise Style'. |
This comment has been minimized.
This comment has been minimized.
| ValueWithFailures<List<T>> result = ValueWithFailures.of(ImmutableList.of()); | ||
| for (CharSource charSource : charSources) { | ||
| ValueWithFailures<List<T>> singleResult = parseFile(charSource, positionType); | ||
| result = result.combinedWith(singleResult, Guavate::concatToList); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| // handle longQuantity and shortQuantity | ||
| double longQuantity = parseQuantity(row, LONG_QUANTITY_FIELD); | ||
| double shortQuantity = parseQuantity(row, SHORT_QUANTITY_FIELD); | ||
| double quantity = longQuantity - shortQuantity; |
This comment has been minimized.
This comment has been minimized.
brianweller89
Sep 14, 2017
Contributor
Probably best to throw an exception or create a failure if quantity, short quantity and long quantity are all not populated.
Silently setting quantity to 0 feels dangerous; it's reasonable to expect clients to always provide a quantity (can always be manually set to 0 in the input if needed)
| private static EtdSettlementType parseEtdSettlementType(String str) { | ||
| String upper = str.toUpperCase(Locale.ENGLISH); | ||
| Map<String, EtdSettlementType> valuesByCode = | ||
| Stream.of(EtdSettlementType.values()).collect(toImmutableMap(EtdSettlementType::getCode)); |
This comment has been minimized.
This comment has been minimized.
brianweller89
Sep 14, 2017
Contributor
Could store a static version of this map rather than recreating it every time the method is called.
| * @param builder the builder to update | ||
| */ | ||
| public default void parsePositionAttributes(CsvRow row, PositionInfoBuilder builder) { | ||
| // do nothing |
This comment has been minimized.
This comment has been minimized.
brianweller89
Sep 14, 2017
Contributor
Given that these are builder mutating methods, 'populate' might be a better name than 'parse'.
Are we assuming that overrides of these methods may set non-attribute values on the builder (e.g. settlement date, trade date)?
If yes then parseInfo would be a better name than parseAttributes
If the methods are only expected to populate attributes then we could return a map of attributes and allow the clients to populate the builder
| public void test_parseInteger() { | ||
| assertEquals(LoaderUtils.parseInteger("2"), 2); | ||
| assertThrowsIllegalArg(() -> LoaderUtils.parseInteger("Rubbish")); | ||
| } |
This comment has been minimized.
This comment has been minimized.
jodastephen commentedSep 11, 2017
Add
PositionCsvLoaderto complementTradeCsvLoader.Update trade loader to parse security trades.
Add extensibility to parser using a plugin, to pickup attributes.