/Strata

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify attribute types #1712

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Reviewers

@brianweller89 brianweller89

Assignees

@brianweller89 brianweller89

Labels
None yet
Projects
None yet
Milestone
  v2.0
2 participants
@jodastephen @brianweller89
@jodastephen
Member

jodastephen commented Jun 5, 2018

Incompatible change that merges TradeAttributeType, PositionAttributeType and SecurityAttributeType.
Interface Attributes for TradeInfo, PositionInfo & SecurityInfo.

Most of the changes are deletions and renames.
@jodastephen
Unify attribute types 
Incompatible change that merges `TradeAttributeType`,
`PositionAttributeType` and `SecurityAttributeType`
Interface `Attributes` for `TradeInfo`, `PositionInfo` & `SecurityInfo`
Loading status checks…
2d8af32

@jodastephen jodastephen assigned brianweller89 Jun 5, 2018

@jodastephen jodastephen requested a review from brianweller89 Jun 5, 2018

@brianweller89 brianweller89 merged commit 4eb348d into master Jun 5, 2018
15 checks passed

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No dependency changes
Details
security/snyk - modules/basics/pom.xml No dependency changes
Details
security/snyk - modules/calc/pom.xml No dependency changes
Details
security/snyk - modules/collect/pom.xml No dependency changes
Details
security/snyk - modules/data/pom.xml No dependency changes
Details
security/snyk - modules/loader/pom.xml No dependency changes
Details
security/snyk - modules/market/pom.xml No dependency changes
Details
security/snyk - modules/math/pom.xml No dependency changes
Details
security/snyk - modules/measure/pom.xml No dependency changes
Details
security/snyk - modules/pom.xml No dependency changes
Details
security/snyk - modules/pricer/pom.xml No dependency changes
Details
security/snyk - modules/product/pom.xml No dependency changes
Details
security/snyk - modules/report/pom.xml No dependency changes
Details

@jodastephen jodastephen deleted the topic/attribute-type branch Jun 6, 2018

@jodastephen jodastephen added this to the v2.0 milestone Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment