Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for duplicate dates removal if combinePeriodsIfNecessary is set to true #2603

Merged
merged 7 commits into from Nov 23, 2023

Conversation

lfathimakn
Copy link
Contributor

@lfathimakn lfathimakn commented Sep 17, 2023

Fix for duplicate dates removal if combinePeriodsIfNecessary is set to true
Issue was reported before in below bug:
#2597

…sary is set to true

Test case for fixing duplicate dates removal if combinePeriodsIfNecessary is set to true
…o true

Fix for duplicate dates removal if combinePeriodsIfNecessary is set to true
Copy link
Member

@jodastephen jodastephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think we can simplify the bond part.

Update FixedCouponBond to combine periods always
Update FixedCouponBond to combine periods always
Copy link
Member

@jodastephen jodastephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jodastephen jodastephen merged commit f1b408f into OpenGamma:main Nov 23, 2023
7 of 8 checks passed
@lfathimakn
Copy link
Contributor Author

Thank you @jodastephen . When will the next version be released which has the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants