Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Search implemented #73

Merged
merged 1 commit into from Mar 16, 2018
Merged

Conversation

richa208
Copy link
Contributor

@richa208 richa208 commented Feb 28, 2018

Fixes issue:

Fixes #30

Changes:

  • A content script is added that would run in the context of web pages.
  • If user has quark extension added then while browsing through any web page if he encounters any algorithm name then while hovering on it 'Search in quark' tooltip would appear, clicking on which quark homepage would open.

pic6

@AdiChat
Copy link
Member

AdiChat commented Mar 4, 2018

Nice work. 👍

This feature will be useful if on clicking on a term, the results page of Quark (instead of the homepage) is opened. Kindly take a look into this. 👍

@richa208 richa208 force-pushed the quick-search branch 2 times, most recently from ba42887 to 41fd68e Compare March 6, 2018 13:00
@richa208
Copy link
Contributor Author

richa208 commented Mar 6, 2018

Now on clicking any such highlighted keyword in a web page, the corresponding results page is directly opened.

quick

@AdiChat
Copy link
Member

AdiChat commented Mar 7, 2018

Nice work 👍

After we click a highlighted word to search in Quark, we are unable to go to the homepage. Other searches and features work smoothly but when we click on the OpenGenus icon on the left top corner to go to the homepage, the initial search result (for the work on the external page) appears.

Kindly take a look at it. 👍

@richa208
Copy link
Contributor Author

richa208 commented Mar 7, 2018

I missed a line due to which every time the initial result page was being shown on pressing the logo.
This has been rectified now.
Thanks @AdiChat for pointing out the mistake. 😅

Open result page
@richa208
Copy link
Contributor Author

@AdiChat Kindly review it and suggest if any other improvements can be done.

@AdiChat
Copy link
Member

AdiChat commented Mar 16, 2018

Looks great 😍

Hope you are enjoying your journey 🚆 with OpenGenus

@AdiChat AdiChat merged commit d6b3490 into OpenGenus:master Mar 16, 2018
@richa208 richa208 deleted the quick-search branch March 17, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick search option
2 participants