Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the format param is always appended to paged catalog urls #98

Merged
merged 1 commit into from Sep 18, 2020

Conversation

eliotjordan
Copy link
Contributor

Closes #97

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.903% when pulling a58ee6c on 97-json-format into 07914db on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.903% when pulling a58ee6c on 97-json-format into 07914db on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.903% when pulling a58ee6c on 97-json-format into 07914db on master.

Copy link
Member

@jkeck jkeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eliotjordan, this worked on all the sites that I had tested, but clearly there are some differences to how some the APIs work (which is a bit troublesome). Thanks for making the fix.

@jkeck jkeck merged commit 5d766aa into master Sep 18, 2020
@jkeck jkeck deleted the 97-json-format branch September 18, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harvester does not have correct parameters on paginated results
3 participants